-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Middlewares #10
Conversation
let email = | ||
json | ||
|> Yojson.Basic.Util.member "email" | ||
|> Yojson.Basic.to_string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not clear to me what the to_string
does, we want to ensure that the "email" thingy is a `String
-- so in the end I guess we need a json_utils module (since we've already similar code in user_model and albatross_json...
overall looks great (on my mobile phone), do we need to check the expiration of the cookie somewhere? (fine to put this as todo, but I think we need to encode the timestamp when the cookie was issued to compare I have no idea why the ocamlformat CI errored. |
Thank you for the review. These are very helpful. |
thanks, merged. subsequent changes can follow in new prs |
This PR introduces continues the work on authentication. It introduces Middlewares, and a first middleware for authentication.
cc @hannesm