Polish suggestions (#6)

* fix bugs in suggestions running

- getting agent during suggestions throwing error if no agent
- not properly awaiting run_fn

* redo ux of suggestion card so title and descriptin are indented same

* add y overflow scroll to suggestions panel

frontend/src/components/editor/chrome/panels/suggestions-panel.tsx

@@ -35,7 +35,7 @@ export const SuggestionsPanel: React.FC = () => {
   };
 
   return (
-    <div className="flex flex-col gap-3 p-4">
+    <div className="flex flex-col gap-3 p-4 overflow-y-auto">
       {suggestions.map((suggestion) => (
         <div
           key={suggestion.id}
@@ -49,17 +49,21 @@ export const SuggestionsPanel: React.FC = () => {
           )}
           onClick={() => handleSuggestionClick(suggestion.title)}
         >
-          <div className="flex items-center gap-2">
-            {suggestion.type === "prompt_warning" ? (
-              <MessageCircleWarningIcon className="h-6 w-6" />
-            ) : (
-              <MessageCircleQuestionIcon className="h-6 w-6" />
-            )}
-            <h3 className="font-medium">{suggestion.title}</h3>
+          <div className="flex items-start gap-2">
+            <div className="flex-shrink-0">
+              {suggestion.type === "prompt_warning" ? (
+                <MessageCircleWarningIcon className="h-6 w-6" />
+              ) : (
+                <MessageCircleQuestionIcon className="h-6 w-6" />
+              )}
+            </div>
+            <div className="flex-1">
+              <h3 className="font-medium">{suggestion.title}</h3>
+              <p className="mt-1 text-sm text-muted-foreground">
+                {suggestion.description}
+              </p>
+            </div>
           </div>
-          <p className="mt-1 text-sm text-muted-foreground">
-            {suggestion.description}
-          </p>
         </div>
       ))}
     </div>

marimo/__init__.py

@@ -83,7 +83,7 @@
     "video",
     "vstack",
 ]
-__version__ = "0.0.4"
+__version__ = "0.0.5"
 
 import marimo._ai as ai
 import marimo._islands as islands

marimo/_ai/agents.py

@@ -1,6 +1,8 @@
 # Copyright 2024 Marimo. All rights reserved.
 from __future__ import annotations
 
+import asyncio
+import inspect
 import uuid
 from dataclasses import dataclass
 from enum import Enum
@@ -49,6 +51,10 @@ class Agent:
     suggestions_fn: Optional[Callable[..., List[Suggestion]]] = None
 
 
+def is_coroutine_function(fn: Callable[..., Any]) -> bool:
+    return asyncio.iscoroutinefunction(fn) or inspect.iscoroutinefunction(fn)
+
+
 @mddoc
 def register_agent(agent: Agent) -> None:
     """Register an LLM agent."""
@@ -69,7 +75,9 @@ async def run_agent(prompt: str, name: Optional[str] = None) -> Any:
     try:
         _registry = get_context().agent_registry
         agent = _registry.get_agent(name)
-        result = agent.run_fn(prompt)
-        return result
+        if is_coroutine_function(agent.run_fn):
+            return await agent.run_fn(prompt)
+        else:
+            return agent.run_fn(prompt)
     except ContextNotInitializedError:
         pass

marimo/_runtime/agents.py

@@ -25,7 +25,9 @@ def get_agent(
                 raise ValueError(f"Agent name '{name}' is not registered.")
             return self._agents[name]
         else:
-            if len(self._agents) != 1:
+            if len(self._agents) == 0:
+                return None
+            elif len(self._agents) > 1:
                 raise ValueError(
                     "No agent name provided and multiple agents are registered."
                 )

marimo/_runtime/runner/hooks_post_execution.py

@@ -224,10 +224,8 @@ async def _broadcast_suggestions(
         return
 
     agent_name = cell.agent_name
-    suggestion_fn = (
-        get_context().agent_registry.get_agent(agent_name).suggestions_fn
-    )
-    if suggestion_fn is None:
+    agent = get_context().agent_registry.get_agent(agent_name)
+    if agent is None or agent.suggestions_fn is None:
         return
 
     async def _update_suggestions(
@@ -236,7 +234,7 @@ async def _update_suggestions(
         suggestions = await suggestion_fn()
         Suggestions(suggestions=suggestions).broadcast()
 
-    asyncio.create_task(_update_suggestions(suggestion_fn))
+    asyncio.create_task(_update_suggestions(agent.suggestions_fn))
 
 
 @kernel_tracer.start_as_current_span("store_reference_to_output")

openapi/api.yaml

@@ -2182,7 +2182,7 @@ components:
       type: object
 info:
   title: marimo API
-  version: 0.0.1
+  version: 0.0.5
 openapi: 3.1.0
 paths:
   /@file/{filename_and_length}: