Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use risc0-ethereum-trie #140

Merged
merged 20 commits into from
Feb 14, 2025
Merged

feat: Use risc0-ethereum-trie #140

merged 20 commits into from
Feb 14, 2025

Conversation

Wollac
Copy link
Contributor

@Wollac Wollac commented Jan 16, 2025

No description provided.

Cargo.toml Outdated
@@ -29,6 +29,11 @@ features = ["unstable"]
version = "1.2.1"
features = ["unstable"]

[workspace.dependencies.risc0-ethereum-trie]
git = "https://github.com/risc0/risc0-ethereum"
branch = "feat/trie"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be changed as soon as the crate is deployed.

Copy link
Contributor

@hashcashier hashcashier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Co-authored-by: Rami <2418646+hashcashier@users.noreply.github.com>
Copy link
Contributor

@hashcashier hashcashier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not dug into why, but this doesn't let the preflight resolve all orphan nodes for some reason. I'm using base mainnet block 25638700 for reference.

@Wollac
Copy link
Contributor Author

Wollac commented Jan 29, 2025

I've not dug into why, but this doesn't let the preflight resolve all orphan nodes for some reason. I'm using base mainnet block 25638700 for reference.

Fixed in cb443ba

Copy link
Contributor

@hashcashier hashcashier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wollac Wollac merged commit 8e5663a into main Feb 14, 2025
7 checks passed
@Wollac Wollac deleted the feat/risc0-ethereum-trie branch February 14, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants