JsComponent: improve error reporting and doccomments #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exyi
force-pushed
the
jscomponent-global-errors
branch
from
f3ef75f to
07b4c42
Compare
tomasherceg
approved these changes
Jun 7, 2024
| control.GetProperty(GlobalProperty) is null or ResolvedPropertyValue { Value: false }) | ||
| { | ||
| yield return new ControlUsageError( | ||
| $"This view does not have any view modules registred, only global JsComponent will work. Add the `Global` property to this component, to make the intent clear.", |
There was a problem hiding this comment.
Suggested change
| $"This view does not have any view modules registred, only global JsComponent will work. Add the `Global` property to this component, to make the intent clear.", | |
| $"This view does not have any view modules registered, only global `JsComponent` will work. Add the `Global` property to this component, to make the intent clear.", |
exyi
force-pushed
the
jscomponent-global-errors
branch
2 times, most recently
from
10eaea6 to
42b02bd
Compare
exyi
force-pushed
the
jscomponent-global-errors
branch
from
42b02bd to
2b8aa1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially adresses #1802