Fly office fixing #36
Conversation
# Conflicts: # base/client/src/main/java/dev/rico/internal/client/projector/factories/ImageViewFactory.java
|
Help! Something is wrong here. Travis is unhappy that DateTimeFieldModel.java has no license header. But I have deleted DateTimeFieldModel.java in source ?! |
There was a problem hiding this comment.
@joha78 can you summarize a bit waht the changes of this PR are?
I see you refactored some things, removed the DateTimeFieldModel and introduced TextInputControlConfigurator (to use it for the Password field) and also extended the Table API with tableDoubleCell, tableIntegerColumand tableDoubleColum.
The added API is clear, I think, but can you share whats the intention of the other changes? :) (DateTimeFieldModel was just not used?)
|
DateTimeFieldModel is a very special remoting model for our date and time input field - karakun decided that it should not be included in rico projector, thus I moved the model into sprouts' own rico component library. TextInputControlConfigurator was introduced because I needed to moved some static code into a place where I can easily reuse it and slightly change its behavior (by overwriting TextInputControlConfigurator's methods in a sub-class that is in sprouts' rico component library). Unused focusedItem-API has been removed. |
|
Thanks for the Update @joha78 :) |
again a large batch of changes that were necessary to make projector work with our software system