Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.0 Normalize canonical expressions #68

Merged
merged 56 commits into from
Feb 26, 2025
Merged

Conversation

remi-dupre
Copy link
Owner

@remi-dupre remi-dupre commented Feb 5, 2025

Fixes #58

📋 Before Merge Checklist

  1. I have chosen a new version number with respect to semver
  2. I have updated the version in these files consistently: Cargo.toml, compact-calendar/Cargo.toml, opening-hours-syntax/Cargo.toml, python/Cargo.toml and pyproject.toml
  3. I have updated CHANGELOG.md

✅ New Big Feature

  1. Add a new fuzz target
  2. Add a new collection of benchmarks
  3. Add a user-friendly Python binding

@remi-dupre remi-dupre changed the title Simplify canonical 1.1.0 Simplify canonical expressions Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 91.39415% with 50 lines in your changes missing coverage. Please review.

Project coverage is 89.53%. Comparing base (ae96957) to head (bf2385c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
opening-hours/src/filter/date_filter.rs 90.47% 14 Missing ⚠️
opening-hours-syntax/src/normalize/paving.rs 91.76% 7 Missing ⚠️
opening-hours/src/opening_hours.rs 84.61% 6 Missing ⚠️
fuzz/src/lib.rs 90.24% 4 Missing ⚠️
opening-hours-syntax/src/error.rs 0.00% 4 Missing ⚠️
opening-hours-syntax/src/rules/day.rs 84.00% 4 Missing ⚠️
opening-hours-syntax/src/normalize/frame.rs 93.02% 3 Missing ⚠️
opening-hours-syntax/src/normalize/canonical.rs 97.05% 2 Missing ⚠️
opening-hours-syntax/src/parser.rs 88.23% 2 Missing ⚠️
opening-hours/src/bin/schedule.rs 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   85.33%   89.53%   +4.20%     
==========================================
  Files          28       33       +5     
  Lines        2045     2446     +401     
==========================================
+ Hits         1745     2190     +445     
+ Misses        300      256      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remi-dupre remi-dupre force-pushed the simplify-canonical branch 3 times, most recently from b515d94 to d2d6c43 Compare February 12, 2025 13:08
@remi-dupre remi-dupre force-pushed the simplify-canonical branch 3 times, most recently from ff734c7 to a898e4f Compare February 12, 2025 21:05
@remi-dupre remi-dupre force-pushed the simplify-canonical branch 2 times, most recently from c40b2e0 to 077aa3d Compare February 23, 2025 16:18
But the code remains 2024-ready
@remi-dupre remi-dupre changed the title 1.1.0 Simplify canonical expressions 1.1.0 Normalize canonical expressions Feb 26, 2025
@remi-dupre remi-dupre merged commit 85be557 into master Feb 26, 2025
32 checks passed
@remi-dupre remi-dupre deleted the simplify-canonical branch February 26, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: rewrite the given OpeningHours string in a shorter/simplified string
1 participant