Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.1: Gen Python stub file #66

Merged
merged 7 commits into from
Feb 3, 2025
Merged

1.0.1: Gen Python stub file #66

merged 7 commits into from
Feb 3, 2025

Conversation

remi-dupre
Copy link
Owner

@remi-dupre remi-dupre commented Feb 3, 2025

📋 Before Merge Checklist

  1. I have chosen a new version number with respect to semver
  2. I have updated the version in these files consistently: Cargo.toml, compact-calendar/Cargo.toml, opening-hours-syntax/Cargo.toml, python/Cargo.toml and pyproject.toml
  3. I have updated CHANGELOG.md

Recent versions of poetry are failing because no Python file is found
and maturin seems to be working just as fine without it.
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 7.31707% with 38 lines in your changes missing coverage. Please review.

Project coverage is 85.32%. Comparing base (cf213b8) to head (ab25810).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
opening-hours-py/src/bin/stub_gen.rs 0.00% 26 Missing ⚠️
opening-hours-py/src/lib.rs 33.33% 4 Missing ⚠️
opening-hours-py/src/types/iterator.rs 0.00% 4 Missing ⚠️
opening-hours-py/src/types/datetime.rs 0.00% 2 Missing ⚠️
opening-hours-py/src/types/timezone.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   86.88%   85.32%   -1.56%     
==========================================
  Files          26       28       +2     
  Lines        2005     2044      +39     
==========================================
+ Hits         1742     1744       +2     
- Misses        263      300      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remi-dupre remi-dupre changed the title Gen stubs 1.0.1: Gen stub Feb 3, 2025
@remi-dupre remi-dupre changed the title 1.0.1: Gen stub 1.0.1: Gen Python stub file Feb 3, 2025
@remi-dupre remi-dupre force-pushed the gen-stubs branch 2 times, most recently from bea01aa to 549b43d Compare February 3, 2025 10:02
@remi-dupre remi-dupre merged commit d7562c1 into master Feb 3, 2025
32 checks passed
@remi-dupre remi-dupre deleted the gen-stubs branch February 3, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant