Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old iOS stuff #24

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Delete old iOS stuff #24

wants to merge 1 commit into from

Conversation

Ericson2314
Copy link
Member

Pretty sure this is no longer used, CI will confirm

Pretty sure this is no longer used, CI will confirm
@Ericson2314 Ericson2314 marked this pull request as draft December 8, 2021 21:38
@Ericson2314 Ericson2314 marked this pull request as ready for review December 8, 2021 23:42
@ali-abrar
Copy link
Member

I'm not sure CI can confirm this, because there's an impure step in creating an actually deployable iOS application.

@Ericson2314 Ericson2314 force-pushed the delete-old-ios branch 2 times, most recently from fe65e06 to ee80289 Compare January 23, 2022 04:48
@Ericson2314
Copy link
Member Author

@ali-abrar if we merged reflex-frp/reflex-platform#769 and did a deploy then I think we can be sure this is safe and merge it too? (And also change the thunk back from pointing to a branch in R-P?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants