Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add color option #14

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add color option #14

wants to merge 2 commits into from

Conversation

jmininger
Copy link
Member

Adds a --color option to set fdiagnostics-color=always

3noch
3noch reviewed May 12, 2020
View reviewed changes
src-bin/ghci.hs
<*> optional (OP.switch
( long "color" <>
help "The option to set colored output via -fdiagnostics-color=always"
))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of Maybe Bool and then applying default in the code you can just apply the default here with <> value True.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we take the color option as a string so we have the same options that ghci has?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3noch 3noch 3noch left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmininger @3noch