Merge https://github.com/denoland/vscode_deno

Fix build regression (duplicated suggestions)

CHANGELOG.md

@@ -3,6 +3,10 @@
 Releases of the extension can be downloaded from
 [Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=redking00.vscode-nbts).
 
+### [3.43.3](https://github.com/denoland/vscode_deno/compare/3.43.2...3.43.3) / 2025.01.30
+
+- chore: include "rootDirs" when transferring compiler options (#1248)
+
 ### [3.43.2](https://github.com/denoland/vscode_deno/compare/3.43.1...3.43.2) / 2025.01.02
 
 - chore: sync css preprocessor documents with the lsp (#1233)

client/package.json

@@ -4,7 +4,7 @@
   "author": "Deno Land Inc.",
   "license": "MIT",
   "private": true,
-  "version": "3.43.2",
+  "version": "3.43.3",
   "publisher": "deno-land",
   "repository": {
     "type": "git",

client/src/commands.ts

@@ -395,8 +395,10 @@ async function maybeShowTsConfigPrompt(
   if (!isObject(compilerOptions)) {
     return;
   }
-  for (const key of UNSUPPORTED_COMMON_COMPILER_OPTIONS) {
-    delete compilerOptions[key];
+  for (const key in compilerOptions) {
+    if (!ALLOWED_COMPILER_OPTIONS.includes(key)) {
+      delete compilerOptions[key];
+    }
   }
   if (Object.entries(compilerOptions).length == 0) {
     return;
@@ -723,40 +725,40 @@ function isDenoDisabledCompletely(): boolean {
   ).every(isScopeDisabled);
 }
 
-const UNSUPPORTED_COMMON_COMPILER_OPTIONS = [
-  "baseUrl",
-  "composite",
-  "declaration",
-  "declarationDir",
-  "declarationMap",
-  "emitBOM",
-  "emitDeclarationOnly",
+// Keep this in sync with the supported compiler options set in CLI. Currently:
+// https://github.com/denoland/deno_config/blob/0.47.1/src/deno_json/ts.rs#L85-L119
+const ALLOWED_COMPILER_OPTIONS = [
+  "allowUnreachableCode",
+  "allowUnusedLabels",
+  "checkJs",
   "emitDecoratorMetadata",
-  "generateCpuProfile",
-  "importHelpers",
-  "incremental",
-  "inlineSourceMap",
-  "inlineSources",
-  "moduleResolution",
-  "newLine",
-  "noEmit",
-  "noEmitHelpers",
-  "noEmitOnError",
-  "outDir",
-  "outFile",
-  "paths",
-  "preserveSymlinks",
-  "preserveWatchOutput",
-  "removeComments",
-  "rootDir",
+  "exactOptionalPropertyTypes",
+  "experimentalDecorators",
+  "isolatedDeclarations",
+  "jsx",
+  "jsxFactory",
+  "jsxFragmentFactory",
+  "jsxImportSource",
+  "jsxPrecompileSkipElements",
+  "lib",
+  "noErrorTruncation",
+  "noFallthroughCasesInSwitch",
+  "noImplicitAny",
+  "noImplicitOverride",
+  "noImplicitReturns",
+  "noImplicitThis",
+  "noPropertyAccessFromIndexSignature",
+  "noUncheckedIndexedAccess",
+  "noUnusedLocals",
+  "noUnusedParameters",
   "rootDirs",
-  "skipLibCheck",
-  "sourceMap",
-  "sourceRoot",
-  "stripInternal",
-  "tsBuildInfoFile",
-  "typeRoots",
-  "watch",
-  "watchDirectory",
-  "watchFile",
+  "strict",
+  "strictBindCallApply",
+  "strictBuiltinIteratorReturn",
+  "strictFunctionTypes",
+  "strictNullChecks",
+  "strictPropertyInitialization",
+  "types",
+  "useUnknownInCatchVariables",
+  "verbatimModuleSyntax",
 ];