RD-14664: SQL parser slow against large queries #499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slow part was identified as parsing lists (the comma separated ones at least), which would lead to a nested cascade of lists of two elements: (1, (2, (3, (4, ...)))) which eventually makes the parser very slow, instead of a single list of items 1,2,3,4,....
I attach two queries, the one used as a template we advertise in the web app, because it's also slow to parse, although it takes less than a second, and the large one that takes minutes. With the patch, both parse much faster (far less than a second).