Persistent pool optimized for FDW #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelbranco80
commented
Jul 22, 2024
bgaidioz
reviewed
Jul 22, 2024
sql-client/src/main/scala/raw/client/sql/SqlConnectionPool.scala
Outdated
Show resolved
Hide resolved
bgaidioz
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a connection pool that is designed specifically for the needs of FDW and Steampipe.
This connection pool tries to keep connections active/alive for as long as possible; this ensures that Steampipe caches, which are per connection, stay alive for as long as possible.
The connection pool has a total global limit on the number of connections. If a new connection needs to be established, it will synchronously try to remove the oldest connection that isn't currently borrowed by anyone.
In addition, it keeps a limit on the number of active connections to a single database - this is done to prevent a single "user" from taking over all available slots.
Finally, it has a background thread that checks the health state of connections in the pool; this picks up one connection at a time (that is not used recently), and uses the JDBC isValid(...) method to check its validity.