RD-11232 sql compiler crash parser computes a wrong line col #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexzerntev
commented
Jul 5, 2024
alexzerntev
commented
- Fixed by striping trail and removing the extra new line
bgaidioz
reviewed
Jul 5, 2024
| @@ -26,7 +26,8 @@ class RawSqlSyntaxAnalyzer(val positions: Positions) extends Parsers(positions) | |||
| val source = StringSource(s) | |||
| val rawErrorListener = new RawSqlErrorListener() | |||
|
|
|||
| val lexer = new PsqlLexer(CharStreams.fromString(s)) | |||
| val striped = s.stripTrailing().stripSuffix("\r\n").stripSuffix("\n").stripSuffix("\r") | |||
There was a problem hiding this comment.
There's no risk there's another token later and we start to shift offsets?
Ah it's the whole code that gets stripped?
torcato
approved these changes
Jul 8, 2024
| @@ -26,7 +26,8 @@ class RawSqlSyntaxAnalyzer(val positions: Positions) extends Parsers(positions) | |||
| val source = StringSource(s) | |||
| val rawErrorListener = new RawSqlErrorListener() | |||
|
|
|||
| val lexer = new PsqlLexer(CharStreams.fromString(s)) | |||
| val striped = s.stripTrailing().stripSuffix("\r\n").stripSuffix("\n").stripSuffix("\r") | |||
There was a problem hiding this comment.
The stripTrainling should remove all white space, no?
Why does it need the stripSuffix's after?
alexzerntev
deleted the
RD-11232-sql-compiler-crash-parser-computes-a-wrong-line-col
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.