RD-11080: SqlCompiler crashes when a query is made of 100% comments #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is to be discussed here is: how to report that error? Technically the whole source code is failed, because no executable is found (that is the current patch). But underlining the whole code as people peacefully type a comment at the top, isn't convenient. Also, even an empty file should trigger an error?
Or can we underline the end (last character) saying the SELECT statement is missing.
Or can we not report anything as a failure, e.g.
GetProgramDescriptionwould contain no errors, but also no "final executable", and fail only upon running? (Just thinking of this now.)