Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed RD-10923: SQL time/timestamps are losing milliseconds #430

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Fixed RD-10923: SQL time/timestamps are losing milliseconds #430

merged 4 commits into from
Sep 5, 2024
+148 −22

Conversation

bgaidioz
Copy link
Collaborator

No description provided.

torcato
torcato approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@torcato torcato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgaidioz bgaidioz force-pushed the RD-10923-sql-time-timestamps-are-losing-milliseconds branch 2 times, most recently from 55b3d23 to cb0f9bc Compare May 16, 2024 12:05
@bgaidioz bgaidioz force-pushed the RD-10923-sql-time-timestamps-are-losing-milliseconds branch from cb0f9bc to 74ee7db Compare May 28, 2024 16:42
@bgaidioz
Copy link
Collaborator Author

bgaidioz commented May 28, 2024 •
edited by raw-ci
Loading

/publish

published version: 0.33.6+8-74ee7db0-SNAPSHOT

@bgaidioz bgaidioz force-pushed the RD-10923-sql-time-timestamps-are-losing-milliseconds branch from 74ee7db to e46db25 Compare May 29, 2024 06:46
@bgaidioz bgaidioz marked this pull request as ready for review May 29, 2024 06:47
@bgaidioz
Copy link
Collaborator Author

bgaidioz commented May 29, 2024 •
edited by raw-ci
Loading

/publish

published version: 0.33.6+1-e46db25b-SNAPSHOT

@bgaidioz bgaidioz force-pushed the RD-10923-sql-time-timestamps-are-losing-milliseconds branch from ad6fc15 to 6b51b21 Compare June 10, 2024 07:53
@bgaidioz
Copy link
Collaborator Author

bgaidioz commented Jun 10, 2024 •
edited by raw-ci
Loading

/publish

published version: 0.33.8+3-6b51b212-SNAPSHOT

@bgaidioz
Copy link
Collaborator Author

bgaidioz commented Jun 10, 2024 •
edited by raw-ci
Loading

/publish

published version: 0.33.8+4-32aa9eea-SNAPSHOT

@bgaidioz bgaidioz force-pushed the RD-10923-sql-time-timestamps-are-losing-milliseconds branch from 32aa9ee to 9f2ad32 Compare June 10, 2024 09:41
@bgaidioz
Copy link
Collaborator Author

bgaidioz commented Jun 10, 2024 •
edited by raw-ci
Loading

/publish

published version: 0.33.8+5-04b44be6-SNAPSHOT

@bgaidioz
Copy link
Collaborator Author

bgaidioz commented Jun 10, 2024 •
edited by raw-ci
Loading

/publish

published version: 0.33.8+6-a3d2f39d-SNAPSHOT

@bgaidioz bgaidioz force-pushed the RD-10923-sql-time-timestamps-are-losing-milliseconds branch from a3d2f39 to 382b053 Compare June 13, 2024 06:21
@bgaidioz bgaidioz force-pushed the RD-10923-sql-time-timestamps-are-losing-milliseconds branch from 382b053 to 82a3cbd Compare June 21, 2024 10:30
@bgaidioz
Copy link
Collaborator Author

bgaidioz commented Jun 24, 2024 •
edited by raw-ci
Loading

/publish

published version: 0.33.12+1-82a3cbd3-SNAPSHOT

@bgaidioz bgaidioz force-pushed the RD-10923-sql-time-timestamps-are-losing-milliseconds branch from 82a3cbd to 9bb7da7 Compare June 25, 2024 11:11
@bgaidioz
Copy link
Collaborator Author

bgaidioz commented Jun 25, 2024 •
edited by raw-ci
Loading

/publish

published version: 0.33.14+1-9bb7da7c-SNAPSHOT

@bgaidioz bgaidioz force-pushed the RD-10923-sql-time-timestamps-are-losing-milliseconds branch from 9bb7da7 to 2244538 Compare July 24, 2024 10:46
@bgaidioz bgaidioz force-pushed the RD-10923-sql-time-timestamps-are-losing-milliseconds branch from 2244538 to 76b57c8 Compare July 31, 2024 13:58
@bgaidioz
Copy link
Collaborator Author

bgaidioz commented Jul 31, 2024 •
edited by raw-ci
Loading

/publish

published version: 0.33.20+3-76b57c8d-SNAPSHOT

@bgaidioz bgaidioz force-pushed the RD-10923-sql-time-timestamps-are-losing-milliseconds branch 2 times, most recently from a32ab38 to 5b1403f Compare August 27, 2024 15:36
bgaidioz
bgaidioz commented Sep 2, 2024
View reviewed changes
sql-compiler/src/main/scala/com/rawlabs/sql/compiler/writers/TypedResultSetCsvWriter.scala
@@ -143,7 +144,8 @@ class TypedResultSetCsvWriter(os: OutputStream, lineSeparator: String, maxRows:
val date = v.getDate(i).toLocalDate
gen.writeString(dateFormatter.format(date))
case _: RawTimeType =>
val time = v.getTime(i).toLocalTime
val sqlTime = v.getTime(i)
Copy link
Collaborator Author

@bgaidioz bgaidioz Sep 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have the same patch as in JSON. And make a specific test to exercise CSV.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Also took care of not displaying .000 when there are zero milliseconds, since it's our convention in CSV.

@bgaidioz bgaidioz force-pushed the RD-10923-sql-time-timestamps-are-losing-milliseconds branch from 5b1403f to c7bcc77 Compare September 5, 2024 07:46
@bgaidioz bgaidioz merged commit 36c415f into main Sep 5, 2024
7 checks passed
@bgaidioz bgaidioz deleted the RD-10923-sql-time-timestamps-are-losing-milliseconds branch September 5, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torcato torcato torcato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgaidioz @torcato