Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql-client): sources dep and require #421

Merged
merged 1 commit into from
May 1, 2024
Merged

fix(sql-client): sources dep and require #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,8 @@ lazy val sqlClient = (project in file("sql-client"))
.dependsOn(
client % "compile->compile;test->test",
snapiFrontend % "compile->compile;test->test",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch but actually we also need to remove the snapiFrontend dependency, since SQL should no longer be depending on Snapi.
If something still breaks on that change, then pass the PR to myself or to @bgaidioz

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still need it as a test dependency because of CredentialsTestContext being part of snapi-frontend

sqlParser % "compile->compile;test->test"
sqlParser % "compile->compile;test->test",
sources % "compile->compile;test->test",
)
.settings(
commonSettings,
Expand Down
1 change: 1 addition & 0 deletions sql-client/src/main/java/module-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
requires java.sql;
requires com.zaxxer.hikari;
requires raw.snapi.frontend;
requires raw.sources;

provides raw.client.api.CompilerServiceBuilder with
raw.client.sql.SqlCompilerServiceBuilder;
Expand Down