Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RD-10763: Replace maybeType by a Decl in ProgramDescription #385

Conversation

bgaidioz
Copy link
Collaborator

@bgaidioz bgaidioz commented Mar 15, 2024

See the JIRA and its related subtasks for all details.

That one is only a fraction of the fix. It permits to describe an SQL program as:

  • no declarations in the decls Map (it has no user declared functions),
  • a defined maybeRunnable declaration as value. With parameters (potentially an empty list if none).

and a Snapi program as:

  • its usual list of declarations, the top-level functions,
  • if it has a final value, a defined maybeRunnable declaration: parameter-less since Snapi doesn't support to evaluate a program as a function.
  • if it has no final value, an undefined maybeRunnable.

The rest of the patch are fixes to the SQL test codes that are testing the compiler API.

@bgaidioz bgaidioz requested a review from miguelbranco80 March 15, 2024 16:19
@bgaidioz
Copy link
Collaborator Author

bgaidioz commented Mar 15, 2024

/publish

will publish utils version: 0.28.40+1-d1891909-SNAPSHOT
will publish client version: 0.28.40+1-d1891909-SNAPSHOT
will publish snapi-parser version: 0.28.40+1-d1891909-SNAPSHOT
will publish snapi-frontend version: 0.28.40+1-d1891909-SNAPSHOT
will publish snapi-truffle version: 0.28.40+1-d1891909-SNAPSHOT
will publish snapi-client version: 0.28.40+1-d1891909-SNAPSHOT
will publish sql-client version: 0.28.40+1-d1891909-SNAPSHOT
published
run 8299258530 success ✔️

@bgaidioz bgaidioz force-pushed the RD-10763-replace-maybe-type-by-maybe-runnable-in-client-api-program-description branch from d189190 to 889b0d8 Compare March 25, 2024 08:32
@bgaidioz bgaidioz marked this pull request as ready for review March 26, 2024 13:22
@bgaidioz bgaidioz merged commit ebee7f2 into main Mar 28, 2024
12 checks passed
@bgaidioz bgaidioz deleted the RD-10763-replace-maybe-type-by-maybe-runnable-in-client-api-program-description branch March 28, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants