Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(snapi-parser)(build): build with maven #383

Merged
merged 12 commits into from
Apr 3, 2024

Conversation

datYori
Copy link
Contributor

@datYori datYori commented Mar 14, 2024

We move from sbt to maven in order to build snapi-parser component

Since snapi-parser is not depending on any other snapi component we take advantage of this task to split the publish job.

We kept the same way of following the git tags for versioning

We now use the antlr4-maven-plugin directly to generate our parsers

We remove every sbt related stuff

RD-10756 internal ref

@datYori datYori force-pushed the build-parser-with-maven branch from f2a42ff to c4e8ff2 Compare March 18, 2024 08:43
@datYori
Copy link
Contributor Author

datYori commented Mar 19, 2024

/publish

run 8344962434 failed ❌

@datYori
Copy link
Contributor Author

datYori commented Mar 19, 2024

/publish

run 8345042676 failed ❌

@datYori
Copy link
Contributor Author

datYori commented Mar 19, 2024

/publish

will publish utils version: 0.28.40+24-e4c748af-SNAPSHOT
will publish client version: 0.28.40+24-e4c748af-SNAPSHOT
will publish snapi-frontend version: 0.28.40+24-e4c748af-SNAPSHOT
will publish snapi-truffle version: 0.28.40+24-e4c748af-SNAPSHOT
will publish snapi-client version: 0.28.40+24-e4c748af-SNAPSHOT
will publish sql-client version: 0.28.40+24-e4c748af-SNAPSHOT
published
run 8347192611 success ✔️

@datYori
Copy link
Contributor Author

datYori commented Mar 25, 2024

/publish

run 8420250312 failed ❌

@datYori
Copy link
Contributor Author

datYori commented Mar 25, 2024

/publish

run 8420283108 failed ❌

@datYori
Copy link
Contributor Author

datYori commented Mar 25, 2024

/publish

run 8420346331 failed ❌

@datYori
Copy link
Contributor Author

datYori commented Mar 25, 2024

/publish

will publish snapi-parser version: 0.28.40+34-f03cfb333
published
run 8420396033 success ✔️

@datYori
Copy link
Contributor Author

datYori commented Mar 26, 2024

/publish

run 8433672735 failed ❌

@datYori
Copy link
Contributor Author

datYori commented Mar 26, 2024

/publish

will publish snapi-parser version: 0.28.40+39-d3ed9e69
published
run 8433738495 success ✔️
run 8433738495 failed ❌

@datYori
Copy link
Contributor Author

datYori commented Mar 26, 2024

/publish

published snapi-parser version: 0.28.40+40-086666dd
run 8434083034/$GITHUB_JOB success ✔️
published utils version: 0.28.40+40-086666dd-SNAPSHOT
published client version: 0.28.40+40-086666dd-SNAPSHOT
published snapi-frontend version: 0.28.40+40-086666dd-SNAPSHOT
published snapi-truffle version: 0.28.40+40-086666dd-SNAPSHOT
published snapi-client version: 0.28.40+40-086666dd-SNAPSHOT
published sql-client version: 0.28.40+40-086666dd-SNAPSHOT
run 8434083034/$GITHUB_JOB success ✔️

@datYori datYori force-pushed the build-parser-with-maven branch from 086666d to 94d9dff Compare March 26, 2024 10:19
@datYori
Copy link
Contributor Author

datYori commented Mar 26, 2024

/publish

published snapi-parser version: 0.28.40+12-146b698c
run 8434457537/ success ✔️

@datYori
Copy link
Contributor Author

datYori commented Mar 26, 2024

/publish

published snapi-parser version: 0.28.40+13-11be6eea
published utils version: 0.28.40+13-11be6eea-SNAPSHOT
published client version: 0.28.40+13-11be6eea-SNAPSHOT
published snapi-frontend version: 0.28.40+13-11be6eea-SNAPSHOT
published snapi-truffle version: 0.28.40+13-11be6eea-SNAPSHOT
published snapi-client version: 0.28.40+13-11be6eea-SNAPSHOT
published sql-client version: 0.28.40+13-11be6eea-SNAPSHOT

@datYori datYori marked this pull request as ready for review March 26, 2024 12:17
@datYori
Copy link
Contributor Author

datYori commented Mar 26, 2024

/publish

published snapi-parser version: 0.28.40+14-1e1ec3ef-SNAPSHOT
published utils version: 0.28.40+14-1e1ec3ef-SNAPSHOT
published client version: 0.28.40+14-1e1ec3ef-SNAPSHOT
published snapi-frontend version: 0.28.40+14-1e1ec3ef-SNAPSHOT
published snapi-truffle version: 0.28.40+14-1e1ec3ef-SNAPSHOT
published snapi-client version: 0.28.40+14-1e1ec3ef-SNAPSHOT
published sql-client version: 0.28.40+14-1e1ec3ef-SNAPSHOT

@datYori
Copy link
Contributor Author

datYori commented Mar 26, 2024

/publish

published snapi-parser version: 0.28.40+17-e9208f46-SNAPSHOT
published utils version: 0.28.40+17-e9208f46-SNAPSHOT
published client version: 0.28.40+17-e9208f46-SNAPSHOT
published snapi-frontend version: 0.28.40+17-e9208f46-SNAPSHOT
published snapi-truffle version: 0.28.40+17-e9208f46-SNAPSHOT
published snapi-client version: 0.28.40+17-e9208f46-SNAPSHOT
published sql-client version: 0.28.40+17-e9208f46-SNAPSHOT

@datYori datYori force-pushed the build-parser-with-maven branch from e9208f4 to 48a2762 Compare April 2, 2024 08:35
@alexzerntev
Copy link
Contributor

alexzerntev commented Apr 2, 2024

Could you please rename it from "snapi-parser" to "parsers" or "raw-parsers" (or maybe you can come up with a better name) because now it also contains sql-parser except for snapi-parser.

@datYori
Copy link
Contributor Author

datYori commented Apr 3, 2024

/publish

published parsers version: 0.28.43+13-15048975-SNAPSHOT
published utils version: 0.28.43+13-15048975-SNAPSHOT
published client version: 0.28.43+13-15048975-SNAPSHOT
published snapi-frontend version: 0.28.43+13-15048975-SNAPSHOT
published snapi-truffle version: 0.28.43+13-15048975-SNAPSHOT
published snapi-client version: 0.28.43+13-15048975-SNAPSHOT
published sql-client version: 0.28.43+13-15048975-SNAPSHOT

@datYori datYori merged commit 996e74d into main Apr 3, 2024
15 checks passed
@datYori datYori deleted the build-parser-with-maven branch April 3, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants