Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RD-10500 stop creating unnecessary closures #344

Merged
merged 26 commits into from
Feb 2, 2024
Merged

RD-10500 stop creating unnecessary closures #344

merged 26 commits into from
Feb 2, 2024

Conversation

alexzerntev
Copy link
Contributor

@alexzerntev alexzerntev commented Jan 26, 2024 •
edited
Loading

  • Fixed collection Build bug.
  • Separated Closures from NonClosures, from lambdas from RecFunctions

@alexzerntev alexzerntev marked this pull request as ready for review January 30, 2024 14:33
@alexzerntev alexzerntev force-pushed the RD-10500-stop-creating-unnecessary-closures branch from 8cce870 to 7772f69 Compare February 1, 2024 14:03
@alexzerntev alexzerntev force-pushed the RD-10500-stop-creating-unnecessary-closures branch from 7772f69 to ad2e5bd Compare February 1, 2024 14:36
@alexzerntev
Copy link
Contributor Author

alexzerntev commented Feb 2, 2024 •
edited by raw-ci
Loading

/publish

will publish utils version: 0.28.20+19-4ec3925f-SNAPSHOT
will publish client version: 0.28.20+19-4ec3925f-SNAPSHOT
will publish snapi-parser version: 0.28.20+19-4ec3925f-SNAPSHOT
will publish snapi-frontend version: 0.28.20+19-4ec3925f-SNAPSHOT
will publish snapi-truffle version: 0.28.20+19-4ec3925f-SNAPSHOT
will publish snapi-client version: 0.28.20+19-4ec3925f-SNAPSHOT
will publish sql-client version: 0.28.20+19-4ec3925f-SNAPSHOT
published
run 7753494149 success ✔️

@alexzerntev
Copy link
Contributor Author

alexzerntev commented Feb 2, 2024 •
edited by raw-ci
Loading

/publish

will publish utils version: 0.28.27+20-533b9058-SNAPSHOT
will publish client version: 0.28.27+20-533b9058-SNAPSHOT
will publish snapi-parser version: 0.28.27+20-533b9058-SNAPSHOT
will publish snapi-frontend version: 0.28.27+20-533b9058-SNAPSHOT
will publish snapi-truffle version: 0.28.27+20-533b9058-SNAPSHOT
will publish snapi-client version: 0.28.27+20-533b9058-SNAPSHOT
will publish sql-client version: 0.28.27+20-533b9058-SNAPSHOT
published
run 7753788560 success ✔️

@alexzerntev
Copy link
Contributor Author

alexzerntev commented Feb 2, 2024 •
edited by raw-ci
Loading

/publish

will publish utils version: 0.28.27+21-f25a06d7-SNAPSHOT
will publish client version: 0.28.27+21-f25a06d7-SNAPSHOT
will publish snapi-parser version: 0.28.27+21-f25a06d7-SNAPSHOT
will publish snapi-frontend version: 0.28.27+21-f25a06d7-SNAPSHOT
will publish snapi-truffle version: 0.28.27+21-f25a06d7-SNAPSHOT
will publish snapi-client version: 0.28.27+21-f25a06d7-SNAPSHOT
will publish sql-client version: 0.28.27+21-f25a06d7-SNAPSHOT
published
run 7755086023 success ✔️

bgaidioz
bgaidioz reviewed Feb 2, 2024
View reviewed changes
snapi-truffle/src/main/java/raw/runtime/truffle/ast/expressions/function/MethodNode.java Outdated
}
// Otherwise it is a lambda
else {
return new Lambda(this.parentFunction.getCallTarget());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it set function to that new Lambda and get it registered?

@alexzerntev alexzerntev requested a review from bgaidioz February 2, 2024 14:00
@alexzerntev alexzerntev merged commit 591d714 into main Feb 2, 2024
12 checks passed
@alexzerntev alexzerntev deleted the RD-10500-stop-creating-unnecessary-closures branch February 2, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgaidioz bgaidioz bgaidioz approved these changes

@miguelbranco80 miguelbranco80 Awaiting requested review from miguelbranco80

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexzerntev @bgaidioz