fix(sql-client): sources dep and require #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/publish
|
| @@ -355,7 +355,8 @@ lazy val sqlClient = (project in file("sql-client")) | |||
| .dependsOn( | |||
| client % "compile->compile;test->test", | |||
| snapiFrontend % "compile->compile;test->test", | |||
There was a problem hiding this comment.
Good catch but actually we also need to remove the snapiFrontend dependency, since SQL should no longer be depending on Snapi.
If something still breaks on that change, then pass the PR to myself or to @bgaidioz
There was a problem hiding this comment.
we still need it as a test dependency because of CredentialsTestContext being part of snapi-frontend
|
/publish
|
|
/publish
|
|
/publish
|
miguelbranco80
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was missing from #414