RD-14693: String.From(<string>) tries to resolve the string into a lo…

…cation (#502)
raw-labs · Sep 17, 2024 · 28e8bd4 · 28e8bd4
1 parent f2d53d5
commit 28e8bd4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/...-compiler/src/test/scala/com/rawlabs/snapi/compiler/tests/builtin/StringPackageTest.scala b/...-compiler/src/test/scala/com/rawlabs/snapi/compiler/tests/builtin/StringPackageTest.scala
@@ -48,6 +48,8 @@ class StringPackageTest extends SnapiTestContext with FailAfterNServer {
 
   test("String.From(true)")(it => it should evaluateTo(""" "true" """))
 
+  test("String.From(\"tralala\")")(it => it should evaluateTo(""" "tralala" """))
+
   test("String.From(Date.Build(1975, 6, 23))")(it => it should evaluateTo(""" "1975-06-23" """))
 
   test("String.From(Timestamp.Build(1975, 6, 23, 9, 30))")(it =>

diff --git a/...nd/src/main/scala/com/rawlabs/snapi/frontend/snapi/extensions/builtin/StringPackage.scala b/...nd/src/main/scala/com/rawlabs/snapi/frontend/snapi/extensions/builtin/StringPackage.scala
@@ -79,6 +79,7 @@ class StringFromEntry extends EntryExtension {
           SnapiDoubleType(),
           SnapiDecimalType(),
           SnapiBoolType(),
+          SnapiStringType(),
           SnapiDateType(),
           SnapiTimeType(),
           SnapiTimestampType(),

diff --git a/...java/com/rawlabs/snapi/truffle/ast/expressions/builtin/string_package/StringFromNode.java b/...java/com/rawlabs/snapi/truffle/ast/expressions/builtin/string_package/StringFromNode.java
@@ -72,6 +72,12 @@ protected String fromBoolean(boolean value) {
     return String.valueOf(value);
   }
 
+  @Specialization
+  @TruffleBoundary
+  protected String fromString(String value) {
+    return value;
+  }
+
   @Specialization
   @TruffleBoundary
   protected String fromDate(DateObject value) {