Fixing bug in identifiers

raw-labs · Jan 23, 2024 · 006d386 · 006d386
1 parent a34072b
commit 006d386
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/sql-client/src/main/scala/raw/client/sql/SqlCodeUtils.scala b/sql-client/src/main/scala/raw/client/sql/SqlCodeUtils.scala
@@ -107,10 +107,7 @@ object SqlCodeUtils {
           }
       }
     }
-    // If we were checking for a second quote and we reached the end, then add the quote to the identifier
-    if (state == CheckQuote) {
-      idn += '"'
-    }
+
     // We reached the end of the string append what is left
     idns += SqlIdentifier(idn.toString(), quoted)
     idns.toSeq

diff --git a/sql-client/src/test/scala/raw/client/sql/TestSqlCodeUtils.scala b/sql-client/src/test/scala/raw/client/sql/TestSqlCodeUtils.scala
@@ -182,9 +182,9 @@ class TestSqlCodeUtils extends AnyFunSuite {
                  |""".stripMargin
 
     val values = Seq(
-      Pos(1, 16) -> Seq(SqlIdentifier("e", quoted = false)),
-      Pos(1, 19) -> Seq(SqlIdentifier("exam", quoted = false)),
-      Pos(1, 28) -> Seq(SqlIdentifier("example", quoted = false), SqlIdentifier("airpo", quoted = false)),
+      Pos(1, 16) -> Seq(SqlIdentifier("ex", quoted = false)),
+      Pos(1, 19) -> Seq(SqlIdentifier("examp", quoted = false)),
+      Pos(1, 28) -> Seq(SqlIdentifier("example", quoted = false), SqlIdentifier("airpor", quoted = false)),
     )
     val analyzer = new SqlCodeUtils(code)
     for((pos, expected) <- values ) {