-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDoc-3168 Add the Create<T> overload that uses PredicateSubscriptionCreationOptions #1977
Merged
ppekrol
merged 2 commits into
ravendb:master
from
Danielle9897:RDoc-3168-subscriptionsAPI
Feb 3, 2025
Merged
RDoc-3168 Add the Create<T> overload that uses PredicateSubscriptionCreationOptions #1977
ppekrol
merged 2 commits into
ravendb:master
from
Danielle9897:RDoc-3168-subscriptionsAPI
Feb 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garayx
approved these changes
Feb 3, 2025
| **Filter** | `Expression<Func<T, bool>>` | Lambda expression defining the filter logic for the subscription. Will be translated to a JavaScript function. | | ||
| **Projection** | `Expression<Func<T, object>>` | Lambda expression defining the projection that will be sent by the subscription for each matching document. Will be translated to a JavaScript function. | | ||
| **Includes** | `Action<ISubscriptionIncludeBuilder<T>>` | An action that defines include clauses for the subscription. [Included documents](../../../client-api/data-subscriptions/creation/examples#create-subscription---include-documents) and/or [included counters](../../../client-api/data-subscriptions/creation/examples#create-subscription---include-counters) will be part of the batch sent by the subscription. Include methods can be chained. | | ||
| **ChangeVector** | `string` | Allows to define a change vector from which the subscription will start processing. Useful for ad-hoc processes that need to process only recent changes. In such cases, you can set the field to _"LastDocument"_ to start processing from the latest document in the collection. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| **ChangeVector** | `string` | Allows to define a change vector from which the subscription will start processing. Useful for ad-hoc processes that need to process only recent changes. In such cases, you can set the field to _"LastDocument"_ to start processing from the latest document in the collection. | | |
| **ChangeVector** | `string` | Allows to define a change vector from which the subscription will start processing. Useful for ad-hoc processes that need to process only recent changes. In such cases, you can set the field to _"LastDocument"_ to start processing from the latest document in the collection, or provide actual Change Vector to start the processing from, by default all documents matching the RQL query will be sent, regardless of their creation time.. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, added
garayx
approved these changes
Feb 3, 2025
70ce30d
to
026df73
Compare
Conflicts are resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
https://issues.hibernatingrhinos.com/issue/RDoc-3168/Document-Data-subscriptions-class-and-Create-overloads-dedicated-to-the-creation-of-subscriptions-with-Predicate
@garayx:
Updated the C# files
Other languages were just copied over to 7.0