Standard layout changes #40
Conversation
The smart resize config block does not need to be stored in a vector as it will remain statically sized. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Use an array sized to PISP_BACK_END_NUM_TILES for the tile list in the backend object. This removes the use of std::vector which will be needed to ensure class BackEnd is of standard-layout type. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
|
@kbingham this a bit more involved than I would have liked, but the changes should allow compilation with the |
|
It seems like |
|
Yes, nothing jumps out as being questionable, or anything. Introducing the new type names definitely makes things read better. I wonder just a teeny bit about wrapping up the array of tiles and the count together, but at that point we're heading down the So it's LGTM from me! |
Switch to using std::array types for the default config parameters read from the JSON config file. This allows the BackEnd class to be standard layout compliant. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
naushir
force-pushed
the
standard_layout
branch
from
7f42923 to
b4352cb
Compare
|
@kbingham this is now ready for you to test at release v1.2.0. I've updated my libcamera Pi 5 branch at https://github.com/naushir/libcamera/tree/pi5_upstream so the wrap file points to the new release as well, so the patches posted on the ML will need updating. |
No description provided.