Skip to content

Commit

Permalink
backend: frontend: Mark class BackEnd and FrontEnd final
Browse files Browse the repository at this point in the history
These cannot be used to make a derived class.  Also change the protected
section to private.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
  • Loading branch information
naushir committed May 9, 2024
1 parent 999da5a commit f30016f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
5 changes: 2 additions & 3 deletions src/libpisp/backend/backend.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
namespace libpisp
{

class BackEnd
class BackEnd final
{
public:
struct Config
Expand Down Expand Up @@ -146,7 +146,7 @@ class BackEnd
return mutex_.try_lock();
}

protected:
private:
void finaliseConfig();
void updateSmartResize();
void updateTiles();
Expand All @@ -168,7 +168,6 @@ class BackEnd
std::vector<SmartResize> smart_resize_;
uint32_t smart_resize_dirty_;

private:
// Default config
std::map<std::string, pisp_be_ccm_config> ycbcr_map_;
std::map<std::string, pisp_be_ccm_config> inverse_ycbcr_map_;
Expand Down
4 changes: 2 additions & 2 deletions src/libpisp/frontend/frontend.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
namespace libpisp
{

class FrontEnd
class FrontEnd final
{
public:
static constexpr uint32_t ScalePrecision = 10;
Expand Down Expand Up @@ -70,7 +70,7 @@ class FrontEnd
return mutex_.try_lock();
}

protected: // TODO: Should be private
private:
void getOutputSize(unsigned int output_num, uint16_t &width, uint16_t &height) const;

const PiSPVariant &variant_;
Expand Down

0 comments on commit f30016f

Please sign in to comment.