This repository was archived by the owner on Jul 30, 2019. It is now read-only.
[REVIEW] Minor changes to conda recipe #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Because dask-cudf has the dependencies like dask, distributed, python and cudf, we can remove them as direct dependencies of dask-cuml. 2. 'test' section can check import of dask_cuml instead of some of its dependencies.
|
Would someone please review this PR ? Thanks. |
cjnolet
suggested changes
Jun 20, 2019
|
Hi @dantegd, Would you please review ? Thanks. |
jakirkham
reviewed
Jun 24, 2019
| @@ -32,27 +32,17 @@ build: | |||
|
|
|||
| requirements: | |||
| build: | |||
| - python | |||
| - cudf 0.7* | |||
| - dask >=0.19.0 | |||
jakirkham
reviewed
Jun 24, 2019
| - dask-cudf 0.7* | ||
| - dask-cuda 0.7* | ||
| run: | ||
| - python | ||
| - cudf 0.7* | ||
| - dask >=0.19.0 |
There was a problem hiding this comment.
Would also keep python and dask here.
There was a problem hiding this comment.
I thought the indirect dependency of python(or dask) through dask-cudf is good enough. Any specific reason why we still want to add them explicitly ?
There was a problem hiding this comment.
It's best practice to list explicit requirements. We are using dask in this library explicitly.
Also we need to list everything in run that we expect to be installed with this package. That includes python.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python and cudf, we can remove them as direct dependencies of
dask-cuml.
its dependencies.