Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace thrust::tuple with cuda::std::tuple #1546

Open
wants to merge 2 commits into
base: branch-25.04
Choose a base branch
from
Open

Replace thrust::tuple with cuda::std::tuple #1546

wants to merge 2 commits into from
+239 −262

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Mar 4, 2025

The former is effectively just an alias and we want to get rid of it

@miscco
Replace thrust::tuple with cuda::std::tuple
e8e0a93 
The former is effectively just an alias and we want to get rid of it
@miscco miscco requested review from a team as code owners March 4, 2025 11:15
@miscco miscco requested review from thomcom, bdice, trxcllnt and isVoid March 4, 2025 11:15
@github-actions github-actions bot added Python Related to Python code libcuspatial Relates to the cuSpatial C++ library labels Mar 4, 2025
@bdice bdice mentioned this pull request Mar 4, 2025
Merged
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 4, 2025
@bdice
Copy link
Contributor

bdice commented Mar 4, 2025

@miscco This appears to be running into compilation issues like:

 $PREFIX/include/libcudf/rapids/thrust/iterator/detail/transform_output_iterator.inl(55): error: no operator "=" matches these operands
            operand types are: thrust::detail::tuple_of_iterator_references<double &, double &, double &, double &> = cuda::std::__4::tuple<double, double, double, double>

https://github.com/rapidsai/cuspatial/actions/runs/13659872808/job/38188389286?pr=1546#step:9:1957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@thomcom thomcom Awaiting requested review from thomcom thomcom is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miscco @bdice