Take vertex_partition_range_offsets(_lasts) using a raft::host_span instead of std::vector constant reference. #4959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
seunghwak
added
breaking
jnke2016
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code cleanup,
graph_view_treturnsvertex_partition_range_offsetsorvertex_partition_range_lastsinstd::vector<vertex_t> const&instead ofraft::host_span. We have been migrating fromstd::vector<> const&toraft::host_spanin function input parameters. In-line with this, this PR updates our code base to useraft::host_spaninstead ofstd::vector<> const&in passingvertex_partition_range_offsets(_lasts).Marked as breaking as few public functions (e.g. unrenumber_int_vertices) now take raft::host_span instead of std::vector<> const.