Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce downloaded test data in CI #4951

Open
wants to merge 1 commit into
base: branch-25.04
Choose a base branch
from

Conversation

ChuckHastings
Copy link
Collaborator

@ChuckHastings ChuckHastings commented Feb 26, 2025

Attempting to improve testing times in CI. The tests run in CI do not require all of the test data that is downloaded. We should be able to skip calling get_test_data.sh since we're not running any of the benchmark tests.

This PR also fixes a few missing annotations in the python tests discovered during test.

DO NOT MERGE: Still experimenting. Just getting rid of the download improves things... it should eliminate the instability and cut down the downloads... but it still looks slow.

Copy link

copy-pr-bot bot commented Feb 26, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ChuckHastings ChuckHastings self-assigned this Feb 26, 2025
@ChuckHastings ChuckHastings added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 26, 2025
@ChuckHastings ChuckHastings marked this pull request as ready for review February 26, 2025 15:11
@ChuckHastings ChuckHastings requested review from a team as code owners February 26, 2025 15:11
@ChuckHastings ChuckHastings added the DO NOT MERGE Hold off on merging; see PR for details label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants