Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Incorrect Directories - [SURE-8597] #1602

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sunilarjun
Copy link
Contributor

@sunilarjun sunilarjun commented Dec 20, 2024

Removing incorrect directories from list of directories used by RKE1, RKE2, and K3s. Also updating admonition and text field. Additionally there was no mention of any type of installation under /usr/local/ on the page to note.
Tied to SURE-8597 and fixes #1363.

… RKE2, and K3s. Also updating admonition.

Signed-off-by: Sunil Singh <sunil.singh@suse.com>
Signed-off-by: Sunil Singh <sunil.singh@suse.com>
Signed-off-by: Sunil Singh <sunil.singh@suse.com>
Copy link
Contributor

@btat btat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case of /var/lib/etcd, it may be valid for RKE. A quick search shows that there are instances of it in the code bases for rancher/rke and rancher/rancher, but I don't know if those bits of code correlate to this ticket.

Also, the feedback from the ticket sounds like it's based off RKE2 so just removing the specific examples mentioned may not be the appropriate solution since the table represents all three distros right now. Having separate lists might help with that. E.g. opt/rke is not mentioned in the ticket, but it's not tied to K3s.

Update documentation with correct list of directories used by rke1, rke2, and k3s

It's not mentioned in the PR description, was the rest of the list verified?

Depending on the role you assigned to the node, some of the directories will or won't be present on the node.

:::important
Depending on the role you assigned to the node, certain directories may or may not be present on the node.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the empty lines before and after the triple colons. Removing them introduces our code to this Prettier issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Rancher Distribution Directories
2 participants