Clarify how user search works #1525
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weyfonk
requested review from
btat,
LucasSaintarbor and
sunilarjun
as code owners
btat
requested changes
Nov 6, 2024
docs/how-to-guides/new-user-guides/manage-clusters/access-clusters/add-users-to-clusters.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/new-user-guides/manage-clusters/projects-and-namespaces.md
Outdated
Show resolved
Hide resolved
This adds a few points which should shed light on how to search users using a drop-down list in Rancher, whether to add users to clusters or to projects.
This explains the difference that it makes as opposed to substring-based search.
This improves formatting of notes on searching users, by making them appear in notes blocks.
This applies suggestions from code review.
weyfonk
force-pushed
the
document-user-search-behaviour
branch
from
bf27827 to
1de75f7
Compare
Thanks for your feedback, I think I've addressed all of it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few points which should shed light on how to search users using a drop-down list in Rancher, whether to add users to clusters or to projects.
Context: rancher/dashboard#12358.
Disclaimer: I have not found a way to test rendering for this, as I kept stumbling upon this issue when building contents locally.