Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to plugins #487

Merged
merged 21 commits into from
Apr 10, 2024
Merged

Remove references to plugins #487

merged 21 commits into from
Apr 10, 2024

Conversation

Milo123459
Copy link
Collaborator

Fixes #480
This PR:

  • Removes the delete command
  • Fixes the add command, allowing it to now deploy template powered databases
  • Removes all references of plugins

@Milo123459 Milo123459 added the release/minor Author minor release label Mar 29, 2024
Copy link

Hello, @Milo123459! Thanks for your submission.

Our team will respond soon. If you need more immediate help, try our Forum or our Discord. Thanks!

Copy link
Contributor

@zuchka zuchka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Milo,

This is looking fantastic. Can we please also update the docs here:

Ideally these should make no mention of plugins anymore. Do you agree?

@Milo123459
Copy link
Collaborator Author

railwayapp/docs#470 :)

Copy link
Contributor

@zuchka zuchka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and this works. add now deploys the new template-powered databases. connect also worked for all four DBs:

CleanShot.2024-04-10.at.01.44.09.mp4

@Milo123459 Milo123459 merged commit 825a97e into master Apr 10, 2024
6 checks passed
@Milo123459 Milo123459 deleted the milo/remove-all-plugins branch April 10, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community release/minor Author minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI still using legacy plugin-related commands / terminology
2 participants