Skip to content

Commit

Permalink
Do not set CMAKE_BUILD_TYPE for MSVC because it is unused
Browse files Browse the repository at this point in the history
MSVC is multi-config generator and it needs config type at build time,
not generation time. Fixes a warning.
  • Loading branch information
rafalh committed Sep 15, 2024
1 parent b5ad951 commit 929e02d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:

- name: Build
working-directory: ${{github.workspace}}/build
run: cmake --build . --config $BUILD_TYPE -j $(nproc)
run: cmake --build . -j $(nproc)

build-msvc:
runs-on: windows-latest
Expand All @@ -47,7 +47,7 @@ jobs:
working-directory: ${{github.workspace}}/build
run: |
call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvars32.bat"
cmake .. -DCMAKE_BUILD_TYPE=%BUILD_TYPE% -A Win32
cmake .. -A Win32
- name: Build
shell: cmd
Expand Down

0 comments on commit 929e02d

Please sign in to comment.