Avoid references to productions views directly (prefer tables) #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example of how export views should look like VS reference to productions views like vw_element_hydrant
Fix damage and installation views
Fix leaks and parts
|
@olivierdalang this should avoid any troubles with having locks on editing views. IMHO it would be to extend this to any export views as said in |
ponceta
changed the title
|
No delta is required (views only) |
5 tasks
|
A bit difficult to review for me, as I have 0 context as to how this is used. Purely from the code it looks fine though, so I'd say if you tested and it seems to still work, it's ok to merge. Merging this should be coordinated with #365 (to ensure we remove the hotfix for sigip, which otherwise will be untested) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of how export views should look like VS reference to productions views like vw_element_hydrant