Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] Make RHEL build optional when creating release #8945

Merged
merged 3 commits into from
Mar 1, 2024
Merged

[GHA] Make RHEL build optional when creating release #8945

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f39390
gha - pin the gh-release action to get the node 20 fix
cderv Mar 1, 2024
ad16f06
builds - make rhel build optional in releases
cderv Mar 1, 2024
96aee6d
Add a message in release about the missing rhel build
cderv Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions .github/workflows/create-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ jobs:
echo -e "\n\nFull ${version} changelog up to this version:\n" >> "release_note.md"
echo -e " * View: https://github.com/${GITHUB_REPOSITORY}/blob/v${version_full}/news/changelog-${version}.md\n" >> "release_note.md"
echo -e " * Download: https://github.com/${GITHUB_REPOSITORY}/releases/download/v${version_full}/changelog.md\n" >> "release_note.md"
echo -e "" >> "release_note.md"
echo -e "Due to an issue with upstream dependency, the RHEL build may not included in this release. Follow #8944 for more information." >> "release_note.md"

- name: Upload Artifact
uses: actions/upload-artifact@v3
Expand Down Expand Up @@ -448,14 +450,14 @@ jobs:
publish-release:
if: ${{ inputs.publish-release }}
runs-on: ubuntu-latest
needs:
[
needs: [
configure,
make-installer-deb,
make-installer-arm64-deb,
make-installer-win,
make-installer-mac,
make-tarball-rhel,
# optional in release to not be blocked by RHEL build depending on conda-forge deno dependency
# make-tarball-rhel,
make-arm64-tarball,
make-tarball,
make-source-tarball,
Expand Down Expand Up @@ -492,9 +494,11 @@ jobs:
sha256sum quarto-${{needs.configure.outputs.version}}-macos.pkg >> ../quarto-${{needs.configure.outputs.version}}-checksums.txt
popd

pushd RHEL\ Zip
sha256sum quarto-${{needs.configure.outputs.version}}-linux-rhel7-amd64.tar.gz >> ../quarto-${{needs.configure.outputs.version}}-checksums.txt
popd
if [ -f "RHEL Zip/quarto-${{needs.configure.outputs.version}}-linux-rhel7-amd64.tar.gz" ]; then
pushd RHEL\ Zip
sha256sum quarto-${{needs.configure.outputs.version}}-linux-rhel7-amd64.tar.gz >> ../quarto-${{needs.configure.outputs.version}}-checksums.txt
popd
fi

pushd Deb\ Zip
sha256sum quarto-${{needs.configure.outputs.version}}-linux-amd64.tar.gz >> ../quarto-${{needs.configure.outputs.version}}-checksums.txt
Expand All @@ -518,7 +522,7 @@ jobs:

- name: Create Release
id: create_release
uses: softprops/action-gh-release@v1
uses: softprops/action-gh-release@4634c16e79c963813287e889244c50009e7f0981
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
Expand All @@ -528,6 +532,7 @@ jobs:
body_path: ./News/release_note.md
draft: false
prerelease: ${{ inputs.pre-release }}
fail_on_unmatched_files: false # rhel build may not be included
files: |
./Source/quarto-${{needs.configure.outputs.version}}.tar.gz
./Deb Zip/quarto-${{needs.configure.outputs.version}}-linux-amd64.tar.gz
Expand All @@ -544,14 +549,14 @@ jobs:

cleanup-when-failure:
if: ${{ (failure() || cancelled()) && inputs.publish-release }}
needs:
[
needs: [
configure,
make-installer-deb,
make-installer-arm64-deb,
make-installer-win,
make-installer-mac,
make-tarball-rhel,
# optional in release to not be blocked by RHEL build depending on conda-forge deno dependency
# make-tarball-rhel,
make-arm64-tarball,
make-tarball,
make-source-tarball,
Expand Down
Loading