Article Layout: Push completely empty margin sidebar to the bottom of z-order #8313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonstyle
force-pushed
the
bugfix/8311
branch
from
69e935d to
97dd13c
Compare
Since the margin element has no children, we can safely push it to the bottom (and in fact, we need to in order to ensure that the links and other elements in the margin are clickable). Fixes #8311
dragonstyle
force-pushed
the
bugfix/8311
branch
from
97dd13c to
f0c53a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the margin element has no children, we can safely push it to the bottom (and in fact, we need to in order to ensure that the links and other elements in the margin are clickable).
Fixes #8311