Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Quarkus 3.19.0, Introduce quarkus.cxf.client.tls-configuration-name to set TLS options for all CXF clients #1723

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Upgrade to Quarkus 3.19.0, Introduce quarkus.cxf.client.tls-configuration-name to set TLS options for all CXF clients #1723

merged 2 commits into from
Feb 24, 2025

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Feb 19, 2025

Fix #1680

@ppalaga ppalaga requested a review from a team as a code owner February 19, 2025 15:19
@ppalaga ppalaga mentioned this pull request Feb 19, 2025
Closed
@ppalaga
Copy link
Contributor Author

ppalaga commented Feb 19, 2025

@dcheng1248 I took your work from #1721 and adapted mostly only the tests. The rest was nearly perfect. Great work, thanks a lot!

@dcheng1248
Copy link
Contributor

@ppalaga thanks a lot for following up and your patience throughout! The tests look much cleaner.
When time allows next week, I will try to learn more about the server side and figure out why the ITs I wrote fail. If I have trouble with this, could I ask you for quick pointers?

@ppalaga
Copy link
Contributor Author

ppalaga commented Feb 24, 2025

why the ITs I wrote fail.

There is no big mistery :D I just screwed the first attempt to implement javax.ssl.net TLS config on Quarkus side: quarkusio/quarkus#46368
The fix is underway: quarkusio/quarkus#46379

@ppalaga
Copy link
Contributor Author

ppalaga commented Feb 24, 2025

0108d44: just rebased. Many native tests are still expected to fail due to quarkusio/quarkus#46368
The fix is merged in Quarkus main and will be backported to Quarkus 3.19.1 due on Wed Feb 26, 2025.
I am going to merge with the failing native tests, release QCXF 3.19.0 and document the issue in release notes.

@ppalaga ppalaga merged commit 4cd669f into quarkiverse:main Feb 24, 2025
14 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce quarkus.cxf.client.tls-configuration-name to set TLS options for all CXF clients
2 participants
@ppalaga @dcheng1248