This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
chore: offboard CLIENT_IM_3364 FF #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymchandra
force-pushed
the
hjf/offboard-ff
branch
from
c40461d to
f087190
Compare
haxxmaxx
approved these changes
Apr 23, 2024
| @@ -6,19 +6,16 @@ | |||
| */ | |||
| const getStylingItems = (flags, styleOptions) => { | |||
| const items = {}; | |||
There was a problem hiding this comment.
There is no need to define an empty object first here, you can just populate it with the axis properties right away
There was a problem hiding this comment.
Thanks, fixed it now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offboard FF CLIENT_IM_3364