Arm backend: fix test_llama.py #9575
Merged
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansnils
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9575
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit e5ba525 with merge base 644b7dd ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
approved these changes
Mar 25, 2025
|
lintrunner, macos, phi_4_mini, moshi and android test fails are unrelated |
|
The Arm sigmoid 32bit test was fixed yesterday lets rebase and retest |
Number of delegates and tolerance has changed so update it.
zingo
requested changes
Mar 25, 2025
|
Oopsie, sorry about that. Should be fixed now. |
|
MacOS Fails unrelated |
zingo
reviewed
Mar 26, 2025
| @@ -112,9 +114,11 @@ def test_llama_tosa_MI(self): | |||
| ) | |||
| .export() | |||
| .to_edge_transform_and_lower() | |||
| .check_count({"torch.ops.higher_order.executorch_call_delegate": 14}) | |||
| .check_count({"torch.ops.higher_order.executorch_call_delegate": 26}) | |||
There was a problem hiding this comment.
Maybe we should uncomment/remove this line until the number is a bit more sane/closer to 0?
zingo
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Number of delegates and tolerance has changed so update it.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218