Arm backend: Size Test for Cortex-M #9569
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digantdesai
requested review from
larryliu0820,
kirklandsign,
JacobSzwejbka,
lucylq,
swolchok and
manuelcandales
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9569
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit 04c29f9 with merge base f174d55 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
digantdesai
added
ciflow/trunk
topic: not user facing
and removed
CLA Signed
facebook-github-bot
added
the
CLA Signed
digantdesai
force-pushed
the
size_test_m
branch
from
364c2d6 to
e30bc7d
Compare
swolchok
reviewed
Mar 25, 2025
.github/scripts/run_nm.py
Outdated
| sys.exit(1) | ||
|
|
||
| def _get_nm_output(self) -> Dict[str, Symbol]: | ||
| args = ["--print-size", "--size-sort", "--reverse-sort", "--demangle"] |
There was a problem hiding this comment.
you might want to specify the format. it can differ between systems.
.github/scripts/run_nm.py
Outdated
Comment on lines
62
to
64
| symbol_pattern = re.compile( | ||
| r"(?P<addr>[0-9a-fA-F]+)\s+(?P<size>[0-9a-fA-F]+)\s+(?P<type>\w)\s+(?P<name>.+)" | ||
| ) | ||
| match = symbol_pattern.match(line) |
There was a problem hiding this comment.
as written, compiling this regex doesn't help. you'd need to store it somewhere that outlives a single call to this function.
There was a problem hiding this comment.
fixed by moving it up out of the function. Thanks.
| @@ -0,0 +1,167 @@ | |||
| # Copyright (c) Meta Platforms, Inc. and affiliates. | |||
There was a problem hiding this comment.
perhaps we could use bloaty?
There was a problem hiding this comment.
yeah I did think about it. This is just nm TBH so not sure if we need it to be more complicated than that. Wrote a python wrapper to print sorted table, and use cross-tools. But bloaty is nice though a bit "bloated" with dependency etc.
digantdesai
force-pushed
the
size_test_m
branch
5 times, most recently
from
74b8c59 to
e3d5815
Compare
Could not find ET installation when cross-compiling.
It should be more in line with Arm Core Platform and TFLite Micro builds.
Prints useful tables about binary size. TODO: expand it to parse linker map and also dump module, objects, and section names with a given symbol.
Just getting started. We will build on top of this.
digantdesai
force-pushed
the
size_test_m
branch
from
e3d5815 to
04c29f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add size test for cortex-M and add it in the CI