-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging hardware specific data in userbench #2420
Conversation
Summary: currently we are saving the device type in this table ie cuda vs rocm vs cpu etc. We want to further update to allow for hardware specific data ie a100 vs h100. Here we are specifying this for cuda based devices only. If using cuda we will dynamically find the gpu model via nvidia-smi and log that model. in this case for H100 we will see "Nvidia H100" and for a100 we will see "NVidia A100" this will allow us to run the same benchmark on both types of gpu and find the difference in the results quickly via scuba at any given time Differential Revision: D61229059
This pull request was exported from Phabricator. Differential Revision: D61229059 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@adamomainz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured it out!
@adamomainz merged this pull request in fdd7def. |
Summary:
currently we are saving the device type in this table ie cuda vs rocm vs cpu etc. We want to further update to allow for hardware specific data ie a100 vs h100. Here we are specifying this for cuda based devices only.
If using cuda we will dynamically find the gpu model via nvidia-smi and log that model.
in this case for H100 we will see "Nvidia H100" and for a100 we will see "NVidia A100"
this will allow us to run the same benchmark on both types of gpu and find the difference in the results quickly via scuba at any given time
Differential Revision: D61229059