Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging hardware specific data in userbench #2420

Closed
wants to merge 1 commit into from
Closed

Conversation

adamomainz
Copy link
Contributor

Summary:
currently we are saving the device type in this table ie cuda vs rocm vs cpu etc. We want to further update to allow for hardware specific data ie a100 vs h100. Here we are specifying this for cuda based devices only.

If using cuda we will dynamically find the gpu model via nvidia-smi and log that model.

in this case for H100 we will see "Nvidia H100" and for a100 we will see "NVidia A100"

this will allow us to run the same benchmark on both types of gpu and find the difference in the results quickly via scuba at any given time

Differential Revision: D61229059

Summary:
currently we are saving the device type in this table ie cuda vs rocm vs cpu etc. We want to further update to allow for hardware specific data ie a100 vs h100. Here we are specifying this for cuda based devices only.

If using cuda we will dynamically find the gpu model via nvidia-smi and log that model.

in this case for H100 we will see "Nvidia H100" and for a100 we will see "NVidia A100"

this will allow us to run the same benchmark on both types of gpu and find the difference in the results quickly via scuba at any given time

Differential Revision: D61229059
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61229059

@danzimm danzimm self-assigned this Aug 15, 2024
@nmacchioni nmacchioni self-requested a review August 15, 2024 21:38
Copy link
Contributor

@nmacchioni nmacchioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facebook-github-bot
Copy link
Contributor

@adamomainz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link

@danzimm danzimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured it out!

@facebook-github-bot
Copy link
Contributor

@adamomainz merged this pull request in fdd7def.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants