Make cache path configurable and include URL in cache key #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 95.55% 95.69% +0.13%
==========================================
Files 8 8
Lines 1057 1068 +11
Branches 126 127 +1
==========================================
+ Hits 1010 1022 +12
+ Misses 28 27 -1
Partials 19 19 ☔ View full report in Codecov by Sentry. |
Including the base URL in the hashed part of the filename just makes sense, even though I'm not aware of any differences in the two public instances of Space-Track (production and testing). Making the cache path configurable helps any downstream testing which might use a mock Space-Track server.
RazerM
force-pushed
the
feature/improve-cache
branch
from
ffcb716 to
ccdd72b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.