-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Test all Python versions on Windows on scheduled runs #13191
base: main
Are you sure you want to change the base?
Conversation
1499446
to
2bb3ed9
Compare
eaabffe
to
5f85788
Compare
And now all the Windows jobs are being disabled. Great. I'll take a look later. |
We should test pip across our entire Python support matrix on Windows, but we don't want to run the test suite across every Python version on very run as it's slow and unlikely to undercover a bug that the boundary jobs won't.
5f85788
to
02277f4
Compare
OK, this is somewhat convoluted, but it does allow us to avoid duplicating the entire Windows job definition. I pulled the idea from https://github.com/orgs/community/discussions/26253#discussioncomment-3250989. Alternatively, if this is too convoluted, we could generate the Windows matrix dynamically in a preceding job and use that to configure the Windows jobs, like https://github.com/FFY00/arch-python-repo/blob/main/.github/workflows/build.yml. |
I tested the syntax in a separate repository:
|
@sbidoul how do you do feel about this approach? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Do you know who will be notified of failures of the scheduled jobs?
I remember being sent a GitHub notification when a workflow failed on a scheduled run, but let's consult the GHA documentation:
Wow, this is not great. It's probably best to create an issue if the scheduled run fails... I'd rather not use a third-party action for this, so I'll try using the gh tool. |
Also, CI is still too flaky (due to #13153) to open a new issue every time a scheduled run fails. This means this is blocked until that issue is fixed. |
Cleaner version of #13014. See #13016 for why we decided to only run Windows CI across all Python versions on a scheduled (currently weekly) basis over all of the time.
Closes #13011.