Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement dirint #44

Merged
merged 4 commits into from
Apr 4, 2015
Merged

implement dirint #44

merged 4 commits into from
Apr 4, 2015

Conversation

wholmgren
Copy link
Member

This PR implements the dirint function based on the MATLAB pvl_dirint.m file. Closes #4.

I've not yet tested the implementation very thoroughly, so let's hold off on merging until I write a few tests.

As suggested in #42, I would prefer to put this function and the disc function in irradiance.py instead of clearsky.py.

@wholmgren wholmgren added this to the 0.2 milestone Mar 30, 2015
@wholmgren
Copy link
Member Author

I think I've tested the dirint function well enough for now. I pulled 4 days of GHI and DNI measurements here in Tucson, AZ, ran them through disc and dirint, and compared the results to DNI measurements. The 'DNI clear' line comes from clearsky.ineichen.

wcigwbbrr0p5gaaaabjru5erkjggg
aznrqcf6a2ptaaaaaelftksuqmcc
7fquqpnxpozz7xgdnnnkslgui5winm1g60s1oj3b2xlwbmsbohvbo4q rbteqv1vgaaadosurbvkgshxxoovc7pdfyzjk3uqxppc8kxhci57sc0bzrm5xzzrkbvcmdc865wrigan7mfqrgzmuafyv9gedbjdkxzznnxi3yxmg551znmlplwo8klqcubipdq1rioym8l74 ffikpcebpwhvq2yjnxpo1qofrts555xzzjk36nmnkxpooeec
gxm1zxaapzaaaaaelftksuqmcc

There are some more specific functional and physical tests in the test suite.

Note the small change in the disc algorithm to make this work (0 instead of nan if calculation gives less than 0).

Again, happy to make improvements, but if nobody cares, I suggest a merge so that other people can discover my mistakes.

@bmu bmu modified the milestones: 0.1, 0.2 Apr 4, 2015
bmu added a commit that referenced this pull request Apr 4, 2015
@bmu bmu merged commit 32696bc into pvlib:master Apr 4, 2015
@wholmgren wholmgren deleted the dirint branch October 28, 2015 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix dirint function
2 participants