-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port notebooks to a gallery #1818
Port notebooks to a gallery #1818
Conversation
def make_github_url(file_name) at conf.py will need modifications
… it will break something
tutorials to tutorials_old tutos_temp to tutorials
…mething like entropy" This reverts commit 244dafd.
Can we have #1763 merged before this one? I've left some TODOs to remove redundant code. Also, I've commented code at
I expect the problem to be at the internal function called on line 617: F1c, F2c = pvlib.irradiance._get_perez_coefficients(modelt) View code. @wholmgren can you have a look at it? TIA. |
@echedey-ls thanks for taking the initiative! That issue is 7 years old and the pvlib documentation has changed a lot since then. I am not sure that 1:1 ports into a new Tutorial section are the right approach at this time. It's worth revisiting #329 especially @kandersolar comment #329 (comment) before going too far here. Unfortunately I no longer have the vision or time to do documentation well and would defer to other maintainers and community members. |
Thanks @wholmgren , I could figure out the issue with the broken tutorial, the error was on my side: just a commented out line. I agree on the view about everything to be fair. However, I think it is worth to reuse the old tutorials (they still work well) and give them presence on the web page, so they are easier to spot for anyone so another source of knowledge for users that don't download the repo, and, what I think is the nicest point, they get tested with CI - better to integrate them today than in 7 years, luckily. Btw I like taking the over-engineering path so we all see how another gallery could benefit us. Or if we prefer just a subsection in the examples gallery. Open to all alternatives, and desiring to improve current docs. On the other hand, if we have a gallery or section of tutorials then that could ease the port of examples to tutorials (if they are more intended to do so) as stated in Kevin's comment in # 329, split long tutorials, or even make an effort and make new ones. Honestly, I believe this PR is on that path, or even if it wasn't, raising discussion for concrete next steps regarding old tutorials would be fine and I would be willing to help with that (if it is a reasonable amount of time, i.e. I can't create a whole new tutorial)
Even if it was just a matter of willingness; we've got your back. |
I am also hesitant to directly dump the tutorial notebooks into a new
I think converting the For whenever we do go forward with this PR in some form, here are a few things I noticed:
|
Uhm, I see. I'll stop working on this PR, feel free to close if you think so, but I'll keep the translated tutorials just in case. Maybe I do tweaks to some of them to leverage future work. Thanks for the in-depth explanation. |
Considering the current state of pvlib, I think it's safe to assume this tutorials will be deleted at some point in the future, so I'm closing this PR as unnecessary. |
[ ] Tests addeddocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.Addresses #120.
I've made a new sphinx gallery out of the content of the .ipynb notebooks.
View documentation front page for this PR
View tutorial gallery
Ported notebooks (checked ones can be reviewed)
atmosphere.ipynb
irradiance.ipynb
pvsystem.ipynb
solarposition.ipynb
tmy.ipynb
tmy_and_diffuse_irrad_models.ipynb
tmy_to_power.ipynb
tracking.ipynb
Checklist of reviewed by me
Various points:
then used a list of regexes to find and replace things
Details
Expect to still find typos regarding that.
Feel free to point missed things and so on.