-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: PVSystem attributes as iterables #1068
Conversation
What's the idea here? The different arrays have different illumination? It's hard to tell if you're planning to continue to the current implementation with loops/list comprehensions or if it's still experimentation. If you are planning to continue to this pattern, let's discuss before you spend too much more time on it. I'd like to think there are better options along the lines of @mikofski's #1067 (comment) |
Ack. Mistake in my comment: the change to Dataframe is in Two arrays at different orientation have different plane-of-array irradiance. The upstream method The downstream method I'm not committed to this pattern, putting some code that runs out for discussion. And I think this code is duck-ish. The |
Closed in favor of #1076 |
docs/sphinx/source/api.rst
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).Notes:
To do: