remove pvsystem.systemdef #1008
Conversation
There was a problem hiding this comment.
I took a look at the source code of the new notebook just for curiosity. The big difference in line count is mostly because table HTML is all in one line now instead of one cell per line. Interestingly, some of the images are encoded as SVG instead of base64 PNG -- very cool. I don't see an issue with those differences except I suppose there will be an inversely large diff next time someone edits the notebooks without using the VSCode plugin.
Minor nits below, feel free to ignore.
pvlib/tests/test_pvsystem.py
Outdated
| 'surface_azimuth': 0, | ||
| 'surface_tilt': 5} | ||
| assert expected == pvsystem.systemdef(meta, 5, 0, .1, 5, 5) | ||
| needs_numpy_1_10, requires_scipy, fail_on_pvlib_version) |
There was a problem hiding this comment.
Tiny nit, this import might fit on one line now
| used in pvlib and its output was not directly compatible with any pvlib | ||
| function. See :py:func:`pvlib.iotools.read_tmy2`, | ||
| :py:func:`pvlib.iotools.read_tmy3`, :py:meth:`pvlib.Location.from_tmy`, and | ||
| :py:class:`pvlib.pvsystem.LocalizedPVSystem` for alternatives. (:issue:`965`) |
There was a problem hiding this comment.
Usually the PR is linked as well, though it's easy to get to from the issue page so I don't care about being a stickler about this.
There was a problem hiding this comment.
Also, this is in the "API Changes with Deprecations" section, but I don't think this was deprecated was it?
Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com>
Thanks that's good to know. I wonder if it's less about vscode and more about jupyterlab vs notebook or newer versions of the dependencies.
Agree that a PR link is a nice to have rather than a necessity.
Thanks for catching this. #1009. |
Tests addeddocs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.I was surprised by the very large number of removed lines in the
pvsystem.ipynbfile. Maybe relevant: I edited and reran the file using the VSCode's jupyter extension. First time doing that, but it looks ok to me. Really dislike keeping those in the main repo.