-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port notebook tutorials to rst with doctests #120
Comments
First, we need a new name for this issue. It sounds like what you really want is something along the lines of "Port notebook tutorials to rst with doctests". Whether or not it makes it into version 0.3 (not 3) is another matter. Regarding the notebooks themselves, I am much more inclined to move the notebooks to their own repo with different administrators than to add CI testing for them here. Also, I'm am very, very, very reluctant to add dependencies on small projects such as RunNotebook. Have you used nbconverts --to-rst flag? I have not, but that seems like the place to start. |
Yes. I would then go ahead with this by the following activities:
OK.
What a bout the following structure:
I would include all existing notebooks and #84 in item 1 above. Number 2 could be notebooks that :
Another question about documentation:
Looking forward on your feedback. |
Discussion basis for pvlib#120 (comment)
We really need people that are less familiar with pvlib and/or python to give their feedback on the documentation issues. What is working and what is not working? There are a few different kinds of tutorials, so here are my thoughts on each:
Hard to say given that they're so new. I'd start with some discussion about the extensibility of the feature and how it can help with reproducibility. Each subclass would then need to discuss its specific reason for existence, how it works, what the options are, etc.
This is a topic for another issue, but I will say here that I am much more interested in a "Why you should use pvlib" page than a "why you should not use this other software" page. |
@wholmgren thanks for the comments. I will not work on this further until we agree on how it should be done. Nevertheless, I personally would include rst docs for item 1 and 2 above. I would suggest to provide a code linked like in the matplotlib gallery. Looking forward to your response. |
I don't understand. Are we in disagreement? It sounds like there is plenty of agreement upon which to get started. And it doesn't all have to happen in one PR.
This is not true. Sharing code through PRs is a great way to make an abstract discussion more concrete using a more precise common language (Python instead of English). This is how #88 and #93 both started. #93 will be merged, but as the original comment makes clear, simply sharing code was the original intent. #88 has generated a lot of discussion, and it could be merged if someone edited it. |
Sorry for the strong term when using "disagreement". I perceived the first response as somehow vague. I just think that there is a difference between code and docs. Docs could be written straight if the structure (ToC) is clear. Sure, more docstrings with examples are an option for specific use help. |
Ok, let's try a different approach. I like the xarray documentation for the following reasons:
How do you feel about doing something similar to this for pvlib? What would the titles be? |
The last commit now has a potential ToC as a list. It is structured from the above example
I think discussing using the list is easier and less effort. For the logo I have some ideas but dono how to polish them. Which software would you use to draw it? Inkscape? |
This implementation seems to be also a good example for our case: |
note to self: |
In conjunction with Location demotion and PVSystem/LocalizedPVSystem/ModelChain addition but now as separate issue:
I think the original intention with notebooks was to offer quick interactive exploration.
But now we find it hard to keep them updated and tested.
Below a way which might help
The text was updated successfully, but these errors were encountered: