Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security compliance logo #655

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Add security compliance logo #655

merged 4 commits into from
Mar 14, 2024

Conversation

Lukeaber
Copy link
Collaborator

Description of proposed changes

Adding the new security compliance logo so that we can use it in the new release of comply.

Screenshot of proposed changes

Screenshot 2024-03-13 at 11 24 33

Screenshot 2024-03-13 at 13 22 36

@Lukeaber Lukeaber requested a review from a team as a code owner March 13, 2024 13:26
CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## react-components 5.34.1 (2024-03-13)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 5.34.2?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick review, and good spot :)

@sean-mckenna
Copy link
Collaborator

Your screenshot looks a bit different than the figma I looked at.

Screenshot 2024-03-13 at 14 34 18

@sean-mckenna
Copy link
Collaborator

sean-mckenna commented Mar 13, 2024

@Lukeaber
Copy link
Collaborator Author

Lukeaber commented Mar 14, 2024

Yeah used svgo to strip down the svg and manually cut out svg element etc. as described on the webste.
Screenshot 2024-03-14 at 09 24 41

Screenshot 2024-03-14 at 09 24 36

@Lukeaber Lukeaber merged commit 6a8dfee into main Mar 14, 2024
2 checks passed
sean-mckenna added a commit that referenced this pull request Dec 6, 2024
* Add security compliance logo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants