-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update generel logger #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DELETED OLD PR BC I COULD CHANGE IT TO DEVELOPMENT.
All comments taking into account
OLD DESCRIPTION:
Updated Xioalongs logger in accordance with Dylan's comment and other considerations.
Note that the two functions get_config_log_path and get_common_logs_path will be redundant in a second when the new model_path solution is merged to the main. So see them as placeholders.
The default setting here is to place all logs centrally which is counter to the ADR on logging generated data (009). Here it is stated that:
"## Decision
This decision involves implementing a logging system for all generated data and enforcing ensemble model checks.
This logging will involve creating a .txt log file in each model-specific folder. The log file will contain the following details:
I don't really know what I think here. I.e. should the central logging be a default that can be overridden if we want to store some logs closer to the thing they pertain to? Or should we force all logs to be centrally stored? I would really like you input here. and we might need to update ADR 009 and 015 accordingly